[Feature / Selectable A11y] making EuiSelectable[searchable] more accessible#3234
Conversation
|
Preview documentation changes for this PR: https://eui.elastic.co/pr_3234/ |
|
Preview documentation changes for this PR: https://eui.elastic.co/pr_3234/ |
|
Preview documentation changes for this PR: https://eui.elastic.co/pr_3234/ |
thompsongl
left a comment
thompsongl
left a comment
There was a problem hiding this comment.
Is this a breaking change?
Yes. EuiSelectableList is part of the public API and now has 2 extra required props. Same with EuiSelectableSearch and its 1 new required prop. Whether they should be part of the public API is debatable, but removing them would also be a breaking change 😄
I noticed that the list in the 'Searchable' example no longer scrolls when operated with the keyboard. Is this intentional?
|
Preview documentation changes for this PR: https://eui.elastic.co/pr_3234/ |
|
@thompsongl fixed! |
thompsongl
left a comment
thompsongl
left a comment
There was a problem hiding this comment.
Looking good 👍
Functionality remains unchanged
thompsongl
added
the
breaking change
|
@cchaos did you still want to review this? |
|
Preview documentation changes for this PR: https://eui.elastic.co/pr_3234/ |
4 participants
Summary
If EuiSelectable is also searchable it becomes an ARIA combobox. Largely, that means moving most of the
aria-*props from the<ul>and onto the<input />or surrounding<div>.Largely this follows the 1.2 combobox spec with just a few fall back properties from 1.0 and 1.1.
Question!
Is this a breaking change?
EuiSelectableSearch and EuiSelectableList had prop changes but neither of those is really intended as a publicly consumable component individually though technically code be. The props for EuiSelectable have not changed.
Checklist
- [ ] Check against all themes for compatibility in both light and dark modes- [ ] Checked in mobile- [ ] Checked in IE11- [ ] Added documentation examples- [ ] A changelog entry exists and is marked appropriately